Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wget ignoring env vars for no_proxy #3580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix wget ignoring env vars for no_proxy #3580

wants to merge 2 commits into from

Conversation

maxenium
Copy link

The cadvisor health check ends up sending requests to proxy instead of localhost.

No_proxy being configured correctly I was able to narrow down the issue to the wget version within the image. As this should never be sent anywhere else than localhost disabling proxy entirely for the health-check is a valid solution.

# docker exec -it cadvisor /bin/sh
/ # wget --help
BusyBox v1.36.1 (2023-11-06 11:32:24 UTC) multi-call binary.
/ # wget --quiet --tries=1 --spider $CADVISOR_HEALTHCHECK_URL
wget: server returned error: HTTP/1.1 403 Forbidden
/ # wget --quiet --tries=1 -Y off --spider $CADVISOR_HEALTHCHECK_URL

@k8s-ci-robot
Copy link
Collaborator

Hi @maxenium. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maxenium
Copy link
Author

/ok-to-test
@iwankgb can you please add the label?

@k8s-ci-robot
Copy link
Collaborator

@maxenium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
@iwankgb can you please add the label?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maxenium
Copy link
Author

maxenium commented Sep 5, 2024 •
edited
Loading

Hi @bobbypage @iwankgb @Creatone @dims @mrunalp,
anyone willing to help me getting this pullrequest to tested and merged?

We are currently getting 60.000req/h against zscaler from only ~500 hosts. Network-guys are not amused 😭.
Thanks!

@iwankgb
Copy link
Collaborator

iwankgb commented Sep 7, 2024

I can't see -Y option in GNU wget manual.

@iwankgb
Copy link
Collaborator

iwankgb commented Sep 7, 2024

It seems to be available in Busybox's wget, but Alpine uses GNU version, as far as I know.

@maxenium
Copy link
Author

@iwankgb are there any objections? Due to the fact that a faulty GNU version is installed it is advised to fix it in the docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxenium @k8s-ci-robot @iwankgb